[ASImageNode] Move to class method of displayWithParameters:isCancelled: for drawing #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
force-pushed
the
MSStaticDrawingImageNode
branch
2 times, most recently
from
3d8298a
to
5356304
Compare
garrettmoon
reviewed
May 5, 2017
| @@ -833,6 +831,11 @@ - (CGRect)threadSafeBounds | |||
| return _threadSafeBounds; | |||
There was a problem hiding this comment.
This should probably call _locked_threadSafeBounds instead?
Source/ASImageNode.mm
Outdated
| @@ -137,7 +148,7 @@ @implementation ASImageNode | |||
| void (^_displayCompletionBlock)(BOOL canceled); | |||
|
|
|||
| // Drawing | |||
| ASImageNodeDrawParameters _drawParameter; | |||
| //ASImageNodeDrawParameters _drawParameter; | |||
Adlai-Holler
approved these changes
May 8, 2017
There was a problem hiding this comment.
Good! Safe, fast, simple.
Over time these parameters classes could:
- Have public interface/be subclassable. Node classes could specify their parameters subclasses through
+drawParametersClass - Be generalized into immutable "NodeState"-type objects that capture the info we need for layout/display/logging/etc.
There's a ton we can build on top of this, but getting rid of the hacky instance draw methods is the first step. Merge at will.
maicki
force-pushed
the
MSStaticDrawingImageNode
branch
from
5356304
to
30e9277
Compare
maicki
force-pushed
the
MSStaticDrawingImageNode
branch
from
f4bdb0f
to
6723643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our effort going forward to make the framework safer to work with and to enable future optimizations like lifting up caching into a generalized way out of ASImageNode and ASTextNode specific ways this PR will remove the instance version of displayWithParameters:isCancelled: in favor of using the class method.